summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGünther Deschner <gd@samba.org>2004-09-29 15:26:38 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 10:52:51 -0500
commit823936d180765e6eac59ba906aaf08438c7b5f7e (patch)
treeb641c0f07b9f2e23bccb042b7f4dc7cac4d83284
parent4edd6528f9f516c05c1ec3f5ad0880475c132c41 (diff)
downloadsamba-823936d180765e6eac59ba906aaf08438c7b5f7e.tar.gz
samba-823936d180765e6eac59ba906aaf08438c7b5f7e.tar.bz2
samba-823936d180765e6eac59ba906aaf08438c7b5f7e.zip
r2753: Workaround for the (rather broken) _samr_query_useraliases rpc-call.
_samr_query_useraliases shows up with all kind of very weird memberships (global-groups, machine-accounts, etc.). Sometimes even if there is no alias-membership at all. One of the biggest mistakes is to convert any unix-group the user is a member of, into an alias by default in get_group_from_gid. get_alias_user_groups should be rewritten to use pdb_enum_alias_memberships. Guenther (This used to be commit 73ab2d2a74d3992167d9304dd41f60ad0805dd67)
-rw-r--r--source3/groupdb/mapping.c15
1 files changed, 1 insertions, 14 deletions
diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c
index 548651dfd5..6725165c3c 100644
--- a/source3/groupdb/mapping.c
+++ b/source3/groupdb/mapping.c
@@ -945,25 +945,12 @@ BOOL get_group_from_gid(gid_t gid, GROUP_MAP *map)
if ( (grp=getgrgid(gid)) == NULL)
return False;
- /*
- * make a group map from scratch if doesn't exist.
- */
-
become_root();
ret = pdb_getgrgid(map, gid);
unbecome_root();
if ( !ret ) {
- map->gid=gid;
- map->sid_name_use=SID_NAME_ALIAS;
-
- /* interim solution until we have a last RID allocated */
-
- sid_copy(&map->sid, get_global_sam_sid());
- sid_append_rid(&map->sid, pdb_gid_to_group_rid(gid));
-
- fstrcpy(map->nt_name, grp->gr_name);
- fstrcpy(map->comment, "Local Unix Group");
+ return False;
}
return True;