diff options
| author | Matthieu Patou <mat@matws.net> | 2012-06-11 10:23:51 -0700 |
|---|---|---|
| committer | Matthieu Patou <mat@samba.org> | 2012-06-11 21:21:11 +0200 |
| commit | 17d5fbde4341d82c8a20dfa0bd94a6db12bebe41 (patch) | |
| tree | 2ba615fcb0cc733d24102715f747b3691b636e5b | |
| parent | 4c33f28dc20849f8f2b0d18083e838601ee715e6 (diff) | |
| download | samba-17d5fbde4341d82c8a20dfa0bd94a6db12bebe41.tar.gz samba-17d5fbde4341d82c8a20dfa0bd94a6db12bebe41.tar.bz2 samba-17d5fbde4341d82c8a20dfa0bd94a6db12bebe41.zip | |
s3-winbindd: add comments about dump_core_setup
This patch is related to change 0ea7152ff479e32e25817e4ddb1c2a1569bad81d
Comments are added to explain why we call dump_core_setup 3 times.
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Mon Jun 11 21:21:11 CEST 2012 on sn-devel-104
| -rw-r--r-- | source3/winbindd/winbindd.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c index 20ee2fc060..1b6f4251b9 100644 --- a/source3/winbindd/winbindd.c +++ b/source3/winbindd/winbindd.c @@ -1350,6 +1350,13 @@ int main(int argc, char **argv, char **envp) } } + /* We call dump_core_setup one more time because the command line can + * set the log file or the log-basename and this will influence where + * cores are stored. Without this call get_dyn_LOGFILEBASE will be + * the default value derived from build's prefix. For EOM this value + * is often not related to the path where winbindd is actually run + * in production. + */ dump_core_setup("winbindd", lp_logfile()); if (is_daemon && interactive) { d_fprintf(stderr,"\nERROR: " @@ -1390,6 +1397,10 @@ int main(int argc, char **argv, char **envp) DEBUG(0, ("error opening config file '%s'\n", get_dyn_CONFIGFILE())); exit(1); } + /* After parsing the configuration file we setup the core path one more time + * as the log file might have been set in the configuration and cores's + * path is by default basename(lp_logfile()). + */ dump_core_setup("winbindd", lp_logfile()); /* Initialise messaging system */ |