summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2010-08-17 14:21:07 +1000
committerAndrew Tridgell <tridge@samba.org>2010-08-17 21:21:50 +1000
commit21729b63f0a43798751517369a032ba8672aeb20 (patch)
treefe034b9906b6160e905295c10134a0d96f8807fa
parent45a2b408ba16ebabedc519a7235b05c104dede6b (diff)
downloadsamba-21729b63f0a43798751517369a032ba8672aeb20.tar.gz
samba-21729b63f0a43798751517369a032ba8672aeb20.tar.bz2
samba-21729b63f0a43798751517369a032ba8672aeb20.zip
s4-drs: allow getncchanges from RODC with WRIT_REP set
w2k8r2 is setting this bit as a RODC. Instead of refusing the replication, we now remove the bit from req8, which means other places in the code that check this bit can stay the same Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--source4/rpc_server/drsuapi/getncchanges.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c
index dcf1dbef5c..ba47b9b040 100644
--- a/source4/rpc_server/drsuapi/getncchanges.c
+++ b/source4/rpc_server/drsuapi/getncchanges.c
@@ -772,10 +772,10 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
samdb_domain_sid(b_state->sam_ctx));
if (security_level == SECURITY_RO_DOMAIN_CONTROLLER &&
(req8->replica_flags & DRSUAPI_DRS_WRIT_REP)) {
- DEBUG(0,(__location__ ": Attempt to do writeable replication by RODC %s\n",
+ DEBUG(3,(__location__ ": Removing WRIT_REP flag for replication by RODC %s\n",
dom_sid_string(mem_ctx,
dce_call->conn->auth_state.session_info->security_token->user_sid)));
- return WERR_DS_DRA_INVALID_PARAMETER;
+ req8->replica_flags &= ~DRSUAPI_DRS_WRIT_REP;
}