diff options
| author | Jeremy Allison <jra@samba.org> | 2006-03-10 17:52:41 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:15:14 -0500 |
| commit | 47a11f8a4c6156965163fd89bef668cd6612b70c (patch) | |
| tree | 48f0f063b22071d0c347baae8b807e06934a87ad | |
| parent | 1b3e1f9b7ce52cb09193aa6f261f6658acb337f2 (diff) | |
| download | samba-47a11f8a4c6156965163fd89bef668cd6612b70c.tar.gz samba-47a11f8a4c6156965163fd89bef668cd6612b70c.tar.bz2 samba-47a11f8a4c6156965163fd89bef668cd6612b70c.zip | |
r14168: Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.
(This used to be commit 754818f8cc0849bddf84b7a534cd65e8dcd932ac)
| -rw-r--r-- | source3/smbd/sesssetup.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/smbd/sesssetup.c b/source3/smbd/sesssetup.c index 98146561b2..d32ff9fa14 100644 --- a/source3/smbd/sesssetup.c +++ b/source3/smbd/sesssetup.c @@ -1044,7 +1044,10 @@ int reply_sesssetup_and_X(connection_struct *conn, char *inbuf,char *outbuf, } else { struct auth_context *plaintext_auth_context = NULL; const uint8 *chal; - if (NT_STATUS_IS_OK(nt_status = make_auth_context_subsystem(&plaintext_auth_context))) { + + nt_status = make_auth_context_subsystem(&plaintext_auth_context); + + if (NT_STATUS_IS_OK(nt_status)) { chal = plaintext_auth_context->get_ntlm_challenge(plaintext_auth_context); if (!make_user_info_for_reply(&user_info, |