summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Liberman <danielvl@gmail.com>2013-09-19 20:28:33 -0300
committerMichael Adam <obnox@samba.org>2013-09-21 05:24:06 +0200
commite24fcf0f3e1b5b19d97a13786b09f069393b06d8 (patch)
treecdee492ead9d67d07afa39a4ea2d8498f6de2b95
parent807628ecac445999e75ec9ea1abdc5f2fde356d6 (diff)
downloadsamba-e24fcf0f3e1b5b19d97a13786b09f069393b06d8.tar.gz
samba-e24fcf0f3e1b5b19d97a13786b09f069393b06d8.tar.bz2
samba-e24fcf0f3e1b5b19d97a13786b09f069393b06d8.zip
Fix bug 10162 - POSIX ACL mapping failing when setting DENY ACE's from Windows.
Fix for ACL problem - not accepting DENY. Code was checking for pointer and not for content. Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Sat Sep 21 05:24:07 CEST 2013 on sn-devel-104
-rw-r--r--source3/smbd/posix_acls.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
index 3b9be9d872..ad1431d761 100644
--- a/source3/smbd/posix_acls.c
+++ b/source3/smbd/posix_acls.c
@@ -1808,7 +1808,7 @@ static bool add_current_ace_to_acl(files_struct *fsp, struct security_ace *psa,
if (current_ace->attr == ALLOW_ACE)
*got_file_allow = True;
- if ((current_ace->attr == DENY_ACE) && got_file_allow) {
+ if ((current_ace->attr == DENY_ACE) && *got_file_allow) {
DEBUG(0,("add_current_ace_to_acl: malformed "
"ACL in file ACL ! Deny entry after "
"Allow entry. Failing to set on file "