summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimo Sorce <idra@samba.org>2010-07-07 23:43:47 -0400
committerSimo Sorce <idra@samba.org>2010-07-07 23:45:50 -0400
commitf0b918473db75ff389a7d2e3bf4a069b8b30d141 (patch)
tree4dd97b4c9781e0962af069334acbaf8a12b2108d
parent90b1a1d29623c6c2abc86e2571b535a7832dd376 (diff)
downloadsamba-f0b918473db75ff389a7d2e3bf4a069b8b30d141.tar.gz
samba-f0b918473db75ff389a7d2e3bf4a069b8b30d141.tar.bz2
samba-f0b918473db75ff389a7d2e3bf4a069b8b30d141.zip
s3:winbindd_samr Do not use static contexts
It is a very bad idea to use a static context within the open function. Use the memory hierarchy to keep track of a client connection.
-rw-r--r--source3/winbindd/winbindd_samr.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index f8004d976f..a2865a0bca 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -40,7 +40,7 @@
static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
struct rpc_pipe_client **samr_pipe)
{
- static struct rpc_pipe_client *cli = NULL;
+ struct rpc_pipe_client *cli = NULL;
struct auth_serversupplied_info *server_info = NULL;
NTSTATUS status;
@@ -58,7 +58,7 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
}
/* create a samr connection */
- status = rpc_pipe_open_internal(talloc_autofree_context(),
+ status = rpc_pipe_open_internal(mem_ctx,
&ndr_table_samr.syntax_id,
rpc_samr_dispatch,
server_info,
@@ -112,7 +112,7 @@ NTSTATUS open_internal_samr_conn(TALLOC_CTX *mem_ctx,
static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
struct rpc_pipe_client **lsa_pipe)
{
- static struct rpc_pipe_client *cli = NULL;
+ struct rpc_pipe_client *cli = NULL;
struct auth_serversupplied_info *server_info = NULL;
NTSTATUS status;
@@ -130,7 +130,7 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
}
/* create a samr connection */
- status = rpc_pipe_open_internal(talloc_autofree_context(),
+ status = rpc_pipe_open_internal(mem_ctx,
&ndr_table_lsarpc.syntax_id,
rpc_lsarpc_dispatch,
server_info,