diff options
| author | Andrew Tridgell <tridge@samba.org> | 2006-05-22 06:17:10 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 14:08:21 -0500 |
| commit | 00e772d747ca9c28961c11bc2ed10cd800c6b0d9 (patch) | |
| tree | e1d01315d1ce1a0a6f3695474b08e0d2d69e08f8 | |
| parent | 8081e4f40276034c47bd799aca64a7d01ffb1bce (diff) | |
| download | samba-00e772d747ca9c28961c11bc2ed10cd800c6b0d9.tar.gz samba-00e772d747ca9c28961c11bc2ed10cd800c6b0d9.tar.bz2 samba-00e772d747ca9c28961c11bc2ed10cd800c6b0d9.zip | |
r15796: this talloc_reference() was causing a memory leak on every NTVFS
request. The problem is that the talloc_free() in
smbsrv_send_reply_nosign() frees this reference, but doesn't free the
memory iself, thus leaving it attached to the connection context.
Metze, what was the idea behind this reference? If we need it, then we
need a corresponding talloc_free() to go with it.
(This used to be commit 2e105a32c78384b16a0e6a6dc8ff504593afef2e)
| -rw-r--r-- | source4/smb_server/smb_server.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/source4/smb_server/smb_server.h b/source4/smb_server/smb_server.h index 0389d79306..de5774a930 100644 --- a/source4/smb_server/smb_server.h +++ b/source4/smb_server/smb_server.h @@ -421,10 +421,6 @@ struct smbsrv_connection { smbsrv_send_error(req, NT_STATUS_NO_MEMORY); \ return; \ } \ - if (!talloc_reference(req->ntvfs, req)) { \ - smbsrv_send_error(req, NT_STATUS_NO_MEMORY); \ - return; \ - } \ req->ntvfs->frontend_data.private_data = req; \ } while (0) |