summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGünther Deschner <gd@samba.org>2011-05-10 15:49:05 +0200
committerGünther Deschner <gd@samba.org>2011-05-10 17:32:58 +0200
commit019f11dd5b3240d05c1abe30dec3d793d6919313 (patch)
treeaadf83abd84ab33bc0bcbcb1c0cc9a127ef54bff
parent3ba3f68e03510e3bb5b7627c200af0395e853bc2 (diff)
downloadsamba-019f11dd5b3240d05c1abe30dec3d793d6919313.tar.gz
samba-019f11dd5b3240d05c1abe30dec3d793d6919313.tar.bz2
samba-019f11dd5b3240d05c1abe30dec3d793d6919313.zip
s3-printing: Fix double free of cups request.
We never free the request in our cups api usage except for here. The reason is probably htis (from the cupsDoConnect API docs): "This function sends the IPP request to the specified server, retrying and authenticating as necessary. The request is freed with ippDelete() after receiving a valid IPP response." Revert "Fix a memory leak in cups_pull_comment_location" This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632. Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
-rw-r--r--source3/printing/print_cups.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 5ef44647fd..ea2fc1d7c4 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -1731,10 +1731,6 @@ bool cups_pull_comment_location(TALLOC_CTX *mem_ctx,
if (response)
ippDelete(response);
- if (request) {
- ippDelete(request);
- }
-
if (language)
cupsLangFree(language);