diff options
| author | Volker Lendecke <vlendec@samba.org> | 2004-01-15 15:36:01 +0000 |
|---|---|---|
| committer | Volker Lendecke <vlendec@samba.org> | 2004-01-15 15:36:01 +0000 |
| commit | 56c23c527b76bb1309c346ecb574ceb7f29c2e96 (patch) | |
| tree | 562dade987c90b54d1d669188c2524c6722f6dca | |
| parent | 617d7c0bcd1f000dcb26cce81ab510f5091dbc67 (diff) | |
| download | samba-56c23c527b76bb1309c346ecb574ceb7f29c2e96.tar.gz samba-56c23c527b76bb1309c346ecb574ceb7f29c2e96.tar.bz2 samba-56c23c527b76bb1309c346ecb574ceb7f29c2e96.zip | |
And another memory corruption in winbind. Arg 3 of safe_strcpy does not
include the terminating 0.
Volker
(This used to be commit 945c7807641e82500c84e833f03f381497f0a2d0)
| -rw-r--r-- | source3/nsswitch/winbindd_group.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/nsswitch/winbindd_group.c b/source3/nsswitch/winbindd_group.c index 3373e409e9..4805e628dd 100644 --- a/source3/nsswitch/winbindd_group.c +++ b/source3/nsswitch/winbindd_group.c @@ -1144,7 +1144,7 @@ enum winbindd_result winbindd_getusersids(struct winbindd_cli_state *state) ofs = 0; for (i = 0; i < num_groups; i++) { const char *s = sid_string_static(user_grpsids[i]); - safe_strcpy(ret + ofs, s, ret_size - ofs); + safe_strcpy(ret + ofs, s, ret_size - ofs - 1); ofs += strlen(ret+ofs) + 1; } |