diff options
| author | Andrew Tridgell <tridge@samba.org> | 2010-09-16 17:04:53 +1000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 2010-09-16 21:09:17 +1000 |
| commit | 5958997a9bc44876c6f3b810689f52e5e3bd6ded (patch) | |
| tree | b8eb0f901597c9c4471b9132b5fbedf6dac60963 | |
| parent | 83a24ff2efd48b0e192024798695f6cfec9000b5 (diff) | |
| download | samba-5958997a9bc44876c6f3b810689f52e5e3bd6ded.tar.gz samba-5958997a9bc44876c6f3b810689f52e5e3bd6ded.tar.bz2 samba-5958997a9bc44876c6f3b810689f52e5e3bd6ded.zip | |
s4-rpcserver: allow saving of bad RPC packets
use:
dcesrv:stubs directory = .
to save files like this:
RPC-netlogon-48-pullfail.dat
when a RPC packet can't be parsed or is unknown. Only enabled in
developer builds
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
| -rw-r--r-- | source4/rpc_server/dcerpc_server.c | 30 |
1 files changed, 28 insertions, 2 deletions
diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c index 09b9b2ac0a..7bd8dcaa2b 100644 --- a/source4/rpc_server/dcerpc_server.c +++ b/source4/rpc_server/dcerpc_server.c @@ -944,6 +944,30 @@ static NTSTATUS dcesrv_alter(struct dcesrv_call_state *call) } /* + possibly save the call for inspection with ndrdump + */ +static void dcesrv_save_call(struct dcesrv_call_state *call, const char *why) +{ +#ifdef DEVELOPER + char *fname; + char *dump_dir; + dump_dir = lpcfg_parm_string(call->conn->dce_ctx->lp_ctx, NULL, "dcesrv", "stubs directory"); + if (!dump_dir) { + return; + } + fname = talloc_asprintf(call, "%s/RPC-%s-%u-%s.dat", + dump_dir, + call->context->iface->name, + call->pkt.u.request.opnum, + why); + if (file_save(fname, call->pkt.u.request.stub_and_verifier.data, call->pkt.u.request.stub_and_verifier.length)) { + DEBUG(0,("RPC SAVED %s\n", fname)); + } + talloc_free(fname); +#endif +} + +/* handle a dcerpc request packet */ static NTSTATUS dcesrv_request(struct dcesrv_call_state *call) @@ -982,15 +1006,17 @@ static NTSTATUS dcesrv_request(struct dcesrv_call_state *call) /* we got an unknown call */ DEBUG(3,(__location__ ": Unknown RPC call %u on %s\n", call->pkt.u.request.opnum, context->iface->name)); - dump_data(3, pull->data, pull->data_size); + dcesrv_save_call(call, "unknown"); + } else { + dcesrv_save_call(call, "pullfail"); } return dcesrv_fault(call, call->fault_code); } if (pull->offset != pull->data_size) { + dcesrv_save_call(call, "extrabytes"); DEBUG(3,("Warning: %d extra bytes in incoming RPC request\n", pull->data_size - pull->offset)); - dump_data(10, pull->data+pull->offset, pull->data_size - pull->offset); } /* call the dispatch function */ |