summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2009-09-15 14:04:22 -0700
committerAndrew Tridgell <tridge@samba.org>2009-09-15 18:45:43 -0700
commit654672008cb8c1293c7637718a84ac40a4476aa6 (patch)
tree7102e4344deca15a6174702cf4fa7f4d29be6685
parent9e0b1a3a1f0ea9ca1b402aa60b8ddbe9ce0c9c10 (diff)
downloadsamba-654672008cb8c1293c7637718a84ac40a4476aa6.tar.gz
samba-654672008cb8c1293c7637718a84ac40a4476aa6.tar.bz2
samba-654672008cb8c1293c7637718a84ac40a4476aa6.zip
tdb: allow reads after prepare commit
We previously only allowed a commit to happen after a prepare commit. It is in fact safe to allow reads between a prepare and a commit, and the s4 replication code can make use of that, so allow it.
-rw-r--r--lib/tdb/common/transaction.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/lib/tdb/common/transaction.c b/lib/tdb/common/transaction.c
index e97fe67b4e..67a035879c 100644
--- a/lib/tdb/common/transaction.c
+++ b/lib/tdb/common/transaction.c
@@ -137,14 +137,6 @@ static int transaction_read(struct tdb_context *tdb, tdb_off_t off, void *buf,
{
uint32_t blk;
- /* Only a commit is allowed on a prepared transaction */
- if (tdb->transaction->prepared) {
- tdb->ecode = TDB_ERR_EINVAL;
- TDB_LOG((tdb, TDB_DEBUG_FATAL, "transaction_read: transaction already prepared, read not allowed\n"));
- tdb->transaction->transaction_error = 1;
- return -1;
- }
-
/* break it down into block sized ops */
while (len + (off % tdb->transaction->block_size) > tdb->transaction->block_size) {
tdb_len_t len2 = tdb->transaction->block_size - (off % tdb->transaction->block_size);