diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2006-09-21 06:34:21 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 14:19:11 -0500 |
| commit | 67231dcbb1c31dc128bcc773de67a86c0b795398 (patch) | |
| tree | 5d7df83cede22ade808910e4ea9be455373e1744 | |
| parent | 8d1b32083eb9f35b5e3de3354480aa5e0e8a76d1 (diff) | |
| download | samba-67231dcbb1c31dc128bcc773de67a86c0b795398.tar.gz samba-67231dcbb1c31dc128bcc773de67a86c0b795398.tar.bz2 samba-67231dcbb1c31dc128bcc773de67a86c0b795398.zip | |
r18779: Not simo's fault, this is actually a bug I introduced a week ago, when I fixed the previous bug in this code.
We need to remove fragments from the incoming fragment list, or else
we leak (actually, we walk free()'ed data as we add/remove elements).
Andrew Bartlett
(This used to be commit 77473d2ef9a7673cebb56b398acf390fd51a08c8)
| -rw-r--r-- | source4/rpc_server/dcerpc_server.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c index f74e522564..a78c424eaa 100644 --- a/source4/rpc_server/dcerpc_server.c +++ b/source4/rpc_server/dcerpc_server.c @@ -1056,7 +1056,10 @@ NTSTATUS dcesrv_input_process(struct dcesrv_connection *dce_conn) DLIST_ADD_END(dce_conn->incoming_fragmented_call_list, call, struct dcesrv_call_state *); return NT_STATUS_OK; - } + } + + /* This removes any fragments we may have had stashed away */ + DLIST_REMOVE(dce_conn->incoming_fragmented_call_list, call); switch (call->pkt.ptype) { case DCERPC_PKT_BIND: |