summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2011-03-30 06:57:05 +0200
committerVolker Lendecke <vl@samba.org>2011-03-30 09:58:33 +0200
commit8486f0fa0495e51d204dca970bf864041123b631 (patch)
tree29203e9948ca1476426ee03bb56b4bd66e64039f
parentde635fe1f71abfdce50e49dc517b4a55f8449c2f (diff)
downloadsamba-8486f0fa0495e51d204dca970bf864041123b631.tar.gz
samba-8486f0fa0495e51d204dca970bf864041123b631.tar.bz2
samba-8486f0fa0495e51d204dca970bf864041123b631.zip
s3: Fix Coverity ID 2236: REVERSE_INULL
We have already dereferenced "b", and the other calls in this loop can only have worked with a valid handle
-rw-r--r--source3/smbd/lanman.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c
index bf2987f907..a04f062274 100644
--- a/source3/smbd/lanman.c
+++ b/source3/smbd/lanman.c
@@ -1148,9 +1148,7 @@ static bool api_DosPrintQEnum(struct smbd_server_connection *sconn,
subcntarr[i] = num_jobs;
subcnt += subcntarr[i];
- if (b && is_valid_policy_hnd(&handle)) {
- dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr);
- }
+ dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr);
}
if (init_package(&desc,queuecnt,subcnt)) {