diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-03-12 17:44:00 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:15:20 -0500 |
| commit | 8790a2e25789bab514f8372d1b048e11fb0bae8b (patch) | |
| tree | 554304d82ec88d4057704ab97a06ef8d2d6588a1 | |
| parent | 15f4c6372ce5aaefa1ab338cd8d0a3aee77b8efc (diff) | |
| download | samba-8790a2e25789bab514f8372d1b048e11fb0bae8b.tar.gz samba-8790a2e25789bab514f8372d1b048e11fb0bae8b.tar.bz2 samba-8790a2e25789bab514f8372d1b048e11fb0bae8b.zip | |
r14245: We've dereferenced argv before, no point in checking.
Fix Coverity bug # 144.
Volker
(This used to be commit d47ee82f068f1dfbae4a1c81e6bd765d5d36f09f)
| -rw-r--r-- | source3/rpcclient/rpcclient.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c index 3f493ce2c5..8d70c6030a 100644 --- a/source3/rpcclient/rpcclient.c +++ b/source3/rpcclient/rpcclient.c @@ -663,13 +663,11 @@ out_free: } */ - if (argv) { - /* NOTE: popt allocates the whole argv, including the - * strings, as a single block. So a single free is - * enough to release it -- we don't free the - * individual strings. rtfm. */ - free(argv); - } + /* NOTE: popt allocates the whole argv, including the + * strings, as a single block. So a single free is + * enough to release it -- we don't free the + * individual strings. rtfm. */ + free(argv); return result; } |