summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2008-08-06 14:02:45 +1000
committerMichael Adam <obnox@samba.org>2008-08-06 10:50:16 +0200
commit8fed76b73e3576ef2279c0ff6c8bc393010443e0 (patch)
treea6559b3b4c05e18f267f9585d25714f363d1f5b2
parent7b35eec609ac8e120939cd129c8ad9580deaaf5f (diff)
downloadsamba-8fed76b73e3576ef2279c0ff6c8bc393010443e0.tar.gz
samba-8fed76b73e3576ef2279c0ff6c8bc393010443e0.tar.bz2
samba-8fed76b73e3576ef2279c0ff6c8bc393010443e0.zip
fixed a fd leak when trying to regain contact to a domain controller
in winbind When a w2k3 DC is rebooted the 139/445 ports come up before the udp/389 cldap port. During this brief period, winbind manages to connect to 139/445 but not to udp 389. It then enters a tight loop where it leaks one fd each time. In a couple of seconds it runs out of file descriptors, and leaves winbind crippled after the DC does finally come up (This used to be commit 57187cafbcc053e75bb54750494df9feabe3a738)
-rw-r--r--source3/winbindd/winbindd_cm.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index b3f8950691..47df4e4058 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1320,6 +1320,7 @@ static bool find_new_dc(TALLOC_CTX *mem_ctx,
TALLOC_FREE(addrs);
num_addrs = 0;
+ close(*fd);
*fd = -1;
goto again;