diff options
| author | Volker Lendecke <vl@samba.org> | 2008-08-31 12:15:35 +0200 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2008-08-31 12:15:35 +0200 |
| commit | 9554f39b1245408e19bba4bda83f280020a49657 (patch) | |
| tree | 078b9af5dbdc2ee0bd39dd959e2433a2a044eec2 | |
| parent | 06dd647fe04535474eab85d110d409781544e7a7 (diff) | |
| download | samba-9554f39b1245408e19bba4bda83f280020a49657.tar.gz samba-9554f39b1245408e19bba4bda83f280020a49657.tar.bz2 samba-9554f39b1245408e19bba4bda83f280020a49657.zip | |
Fix Coverity ID 589, dead code
(This used to be commit 67c0835226e189deba5856710a1dea19ac5f30fd)
| -rw-r--r-- | source3/nsswitch/libwbclient/wbc_sid.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/source3/nsswitch/libwbclient/wbc_sid.c b/source3/nsswitch/libwbclient/wbc_sid.c index 324a19bd56..f4ffa4e5ca 100644 --- a/source3/nsswitch/libwbclient/wbc_sid.c +++ b/source3/nsswitch/libwbclient/wbc_sid.c @@ -294,9 +294,18 @@ wbcErr wbcLookupSid(const struct wbcDomainSid *sid, } } else { +#if 0 + /* + * Found by Coverity: In this particular routine we can't end + * up here with a non-NULL name. Further up there are just two + * exit paths that lead here, neither of which leave an + * allocated name. If you add more paths up there, re-activate + * this. + */ if (name != NULL) { talloc_free(name); } +#endif if (domain != NULL) { talloc_free(domain); } |