diff options
| author | Matthias Dieter Wallnöfer <mdw@samba.org> | 2010-11-01 15:23:48 +0100 |
|---|---|---|
| committer | Matthias Dieter Wallnöfer <mdw@samba.org> | 2010-11-03 16:20:55 +0000 |
| commit | 9d4eeaeb194d071f02b19aaca3ad1b89d81d3637 (patch) | |
| tree | 179cdedb7e17367a03b939a2d99a8a9da5316205 | |
| parent | d873fb72bc3f7b410a66f98b5045101292718717 (diff) | |
| download | samba-9d4eeaeb194d071f02b19aaca3ad1b89d81d3637.tar.gz samba-9d4eeaeb194d071f02b19aaca3ad1b89d81d3637.tar.bz2 samba-9d4eeaeb194d071f02b19aaca3ad1b89d81d3637.zip | |
s4:objectclass LDB module - the structural objectclass has always to be specified
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov 3 16:20:55 UTC 2010 on sn-devel-104
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/objectclass.c | 6 | ||||
| -rwxr-xr-x | source4/dsdb/tests/python/ldap.py | 19 |
2 files changed, 25 insertions, 0 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/objectclass.c b/source4/dsdb/samdb/ldb_modules/objectclass.c index 474e848c60..9483d3e019 100644 --- a/source4/dsdb/samdb/ldb_modules/objectclass.c +++ b/source4/dsdb/samdb/ldb_modules/objectclass.c @@ -518,6 +518,12 @@ static int objectclass_do_add(struct oc_context *ac) talloc_free(mem_ctx); return LDB_ERR_OBJECT_CLASS_VIOLATION; } + if (objectclass_element->num_values == 0) { + ldb_asprintf_errstring(ldb, "objectclass: Cannot add %s, at least one (structural) objectclass has to be specified!", + ldb_dn_get_linearized(msg->dn)); + talloc_free(mem_ctx); + return LDB_ERR_CONSTRAINT_VIOLATION; + } /* Here we do now get the "objectClass" list from the * database. */ diff --git a/source4/dsdb/tests/python/ldap.py b/source4/dsdb/tests/python/ldap.py index e8bc625807..36c12a2930 100755 --- a/source4/dsdb/tests/python/ldap.py +++ b/source4/dsdb/tests/python/ldap.py @@ -152,6 +152,15 @@ class BasicTests(unittest.TestCase): try: self.ldb.add({ "dn": "cn=ldaptestuser,cn=users," + self.base_dn, + "objectClass": [] }) + self.fail() + except LdbError, (num, _): + self.assertEquals(num, ERR_CONSTRAINT_VIOLATION) + + # Invalid objectclass specified + try: + self.ldb.add({ + "dn": "cn=ldaptestuser,cn=users," + self.base_dn, "objectClass": "X" }) self.fail() except LdbError, (num, _): @@ -304,6 +313,16 @@ class BasicTests(unittest.TestCase): except LdbError, (num, _): self.assertEquals(num, ERR_OBJECT_CLASS_VIOLATION) + # We cannot remove all object classes by an empty replace + m = Message() + m.dn = Dn(ldb, "cn=ldaptestuser,cn=users," + self.base_dn) + m["objectClass"] = MessageElement([], FLAG_MOD_REPLACE, "objectClass") + try: + ldb.modify(m) + self.fail() + except LdbError, (num, _): + self.assertEquals(num, ERR_OBJECT_CLASS_VIOLATION) + m = Message() m.dn = Dn(ldb, "cn=ldaptestuser,cn=users," + self.base_dn) m["objectClass"] = MessageElement(["top", "computer"], FLAG_MOD_REPLACE, |