summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2012-12-06 15:14:07 +0100
committerGünther Deschner <gd@samba.org>2012-12-12 15:00:02 +0100
commitb8ed2efb50b4a689e02b86d4c626d96ee7b2717f (patch)
tree1312c2f52d7f7d3d8e0025df74583e74961b8e9d
parentaf18339e037e388ddac4a417544c295bcc44b31d (diff)
downloadsamba-b8ed2efb50b4a689e02b86d4c626d96ee7b2717f.tar.gz
samba-b8ed2efb50b4a689e02b86d4c626d96ee7b2717f.tar.bz2
samba-b8ed2efb50b4a689e02b86d4c626d96ee7b2717f.zip
nsswitch: Cleanup code in parse_wbinfo_domain_user().
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
-rw-r--r--nsswitch/wbinfo.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/nsswitch/wbinfo.c b/nsswitch/wbinfo.c
index 0e102dc858..b96b73c2bf 100644
--- a/nsswitch/wbinfo.c
+++ b/nsswitch/wbinfo.c
@@ -121,7 +121,8 @@ static bool parse_wbinfo_domain_user(const char *domuser, fstring domain,
if (!p) {
/* Maybe it was a UPN? */
- if ((p = strchr(domuser, '@')) != NULL) {
+ p = strchr(domuser, '@');
+ if (p != NULL) {
fstrcpy(domain, "");
fstrcpy(user, domuser);
return true;