diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2008-07-23 16:14:20 +1000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2008-07-23 16:14:20 +1000 |
| commit | d6fdd13dec854c681ad047d104ccfc2bf0ca5de5 (patch) | |
| tree | c660fc53c10227cbd7cf1f3f294f83e4e5d71ef5 | |
| parent | e0bd9e82eae6dc3623a247b4294659faeb23a20d (diff) | |
| download | samba-d6fdd13dec854c681ad047d104ccfc2bf0ca5de5.tar.gz samba-d6fdd13dec854c681ad047d104ccfc2bf0ca5de5.tar.bz2 samba-d6fdd13dec854c681ad047d104ccfc2bf0ca5de5.zip | |
Remove the 'accoc_group_id' check in the RPC server.
This check breaks more than it fixes, and while technically not
correct, is the best solution we have at this time. Otherwise,
SCHANNEL binds from WinXP fail.
Andrew Bartlett
(This used to be commit f8628fa330abcd50923d995d5bda1f4811582ea9)
| -rw-r--r-- | source4/rpc_server/dcerpc_server.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c index d8dafd61f6..91ae5fcd94 100644 --- a/source4/rpc_server/dcerpc_server.c +++ b/source4/rpc_server/dcerpc_server.c @@ -534,9 +534,20 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call) uint32_t context_id; const struct dcesrv_interface *iface; +#if 0 + /* It is not safe to enable this check - windows clients + * (WinXP in particular) will use it for NETLOGON calls, for + * the subsequent SCHANNEL bind. It turns out that NETLOGON + * calls include no policy handles, so it is safe there. Let + * the failure occour on the attempt to reuse a poilcy handle, + * rather than here */ + + /* Association groups allow policy handles to be shared across + * multiple client connections. We don't implement this yet. */ if (call->pkt.u.bind.assoc_group_id != 0) { return dcesrv_bind_nak(call, 0); } +#endif if (call->pkt.u.bind.num_contexts < 1 || call->pkt.u.bind.ctx_list[0].num_transfer_syntaxes < 1) { |