diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-03-07 16:28:05 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:11:01 -0500 |
| commit | fde330498171c6215a78a72df8be0a20b51cdb32 (patch) | |
| tree | cdfeb45c285ce4118cdb7d18a753758fa2d1d7aa | |
| parent | c2288e6db34207948413411764175990f563168e (diff) | |
| download | samba-fde330498171c6215a78a72df8be0a20b51cdb32.tar.gz samba-fde330498171c6215a78a72df8be0a20b51cdb32.tar.bz2 samba-fde330498171c6215a78a72df8be0a20b51cdb32.zip | |
r13955: Fix Coverity ID 139.
Not a bug in the strictest sense, more a clarification. This whole routine
assumes new_gid != NULL anyway, so there's no point in checking.
Volker
(This used to be commit dfbf09c772b9588271e2d8e053c7494bb087c544)
| -rw-r--r-- | source3/groupdb/mapping.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c index 5ebc9eb4f5..93e7169204 100644 --- a/source3/groupdb/mapping.c +++ b/source3/groupdb/mapping.c @@ -868,7 +868,7 @@ int smb_create_group(const char *unix_group, gid_t *new_gid) if ( *lp_addgroup_script() ) { pstrcpy(add_script, lp_addgroup_script()); pstring_sub(add_script, "%g", unix_group); - ret = smbrun(add_script, (new_gid!=NULL) ? &fd : NULL); + ret = smbrun(add_script, &fd); DEBUG(ret ? 0 : 3,("smb_create_group: Running the command `%s' gave %d\n",add_script,ret)); if (ret != 0) return ret; |