summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2006-12-20 16:58:10 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 14:29:32 -0500
commit02b65d5453c1f6846387f7431d7dfc0a38bc5235 (patch)
tree3e7a061f5d1a49613b4226857f0d9c36cfaa9875
parent089eda9585dfcb36bc6a7fb3c714289bb17cd5e9 (diff)
downloadsamba-02b65d5453c1f6846387f7431d7dfc0a38bc5235.tar.gz
samba-02b65d5453c1f6846387f7431d7dfc0a38bc5235.tar.bz2
samba-02b65d5453c1f6846387f7431d7dfc0a38bc5235.zip
r20288: fix a mem leak and remove useless code
metze (This used to be commit 6d0c788f3dffb7a553464404ebd9c0487d668bc5)
-rw-r--r--source4/librpc/ndr/ndr_drsuapi.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/source4/librpc/ndr/ndr_drsuapi.c b/source4/librpc/ndr/ndr_drsuapi.c
index 5a8acf8dab..f8f84f8c70 100644
--- a/source4/librpc/ndr/ndr_drsuapi.c
+++ b/source4/librpc/ndr/ndr_drsuapi.c
@@ -100,8 +100,8 @@ NTSTATUS ndr_push_drsuapi_DsReplicaOID(struct ndr_push *ndr, int ndr_flags, cons
}
} else {
_OID_PUSH_CHECK(ber_write_OID_String(&blob, r->oid));
- talloc_steal(ndr, blob.data);
}
+ talloc_steal(ndr, blob.data);
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, blob.length));
NDR_CHECK(ndr_push_array_uint8(ndr, NDR_SCALARS, blob.data, blob.length));
@@ -145,8 +145,6 @@ NTSTATUS ndr_pull_drsuapi_DsReplicaOID(struct ndr_pull *ndr, int ndr_flags, stru
NT_STATUS_HAVE_NO_MEMORY(_oid);
} else {
_OID_PULL_CHECK(ber_read_OID_String(_oid_array, &_oid));
- talloc_steal(r->oid, _oid);
- r->oid = _oid;
}
data_blob_free(&_oid_array);
talloc_steal(r->oid, _oid);