summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2011-03-06 12:02:05 +0100
committerVolker Lendecke <vlendec@samba.org>2011-03-06 13:37:13 +0100
commit233c8bca3bfda4d09d458b842873621a7ffe5e91 (patch)
treee4aad11c50487355e07aecefed6e9cc6191ceb3b
parent82785957f0eca5722914ac0607ba2b3a53198d58 (diff)
downloadsamba-233c8bca3bfda4d09d458b842873621a7ffe5e91.tar.gz
samba-233c8bca3bfda4d09d458b842873621a7ffe5e91.tar.bz2
samba-233c8bca3bfda4d09d458b842873621a7ffe5e91.zip
s3: Remove close_fn from idmap_methods
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 6 13:37:13 CET 2011 on sn-devel-104
-rw-r--r--source3/include/idmap.h3
-rw-r--r--source3/winbindd/idmap.c14
-rw-r--r--source3/winbindd/idmap_ad.c23
-rw-r--r--source3/winbindd/idmap_adex/idmap_adex.c12
-rw-r--r--source3/winbindd/idmap_autorid.c7
-rw-r--r--source3/winbindd/idmap_hash/idmap_hash.c9
-rw-r--r--source3/winbindd/idmap_ldap.c6
-rw-r--r--source3/winbindd/idmap_nss.c6
-rw-r--r--source3/winbindd/idmap_passdb.c6
-rw-r--r--source3/winbindd/idmap_rid.c6
-rw-r--r--source3/winbindd/idmap_tdb.c6
11 files changed, 0 insertions, 98 deletions
diff --git a/source3/include/idmap.h b/source3/include/idmap.h
index 2f95740f3d..7b3d6decf2 100644
--- a/source3/include/idmap.h
+++ b/source3/include/idmap.h
@@ -57,9 +57,6 @@ struct idmap_methods {
/* Allocate a Unix-ID. */
NTSTATUS (*allocate_id)(struct idmap_domain *dom, struct unixid *id);
-
- /* Called when backend is unloaded */
- NTSTATUS (*close_fn)(struct idmap_domain *dom);
};
#include "winbindd/idmap_proto.h"
diff --git a/source3/winbindd/idmap.c b/source3/winbindd/idmap.c
index 76310e02ba..a2a727cdb0 100644
--- a/source3/winbindd/idmap.c
+++ b/source3/winbindd/idmap.c
@@ -153,18 +153,6 @@ NTSTATUS smb_register_idmap(int version, const char *name,
return NT_STATUS_OK;
}
-static int close_domain_destructor(struct idmap_domain *dom)
-{
- NTSTATUS ret;
-
- ret = dom->methods->close_fn(dom);
- if (!NT_STATUS_IS_OK(ret)) {
- DEBUG(3, ("Failed to close idmap domain [%s]!\n", dom->name));
- }
-
- return 0;
-}
-
static bool parse_idmap_module(TALLOC_CTX *mem_ctx, const char *param,
char **pmodulename, char **pargs)
{
@@ -343,8 +331,6 @@ static struct idmap_domain *idmap_init_domain(TALLOC_CTX *mem_ctx,
goto fail;
}
- talloc_set_destructor(result, close_domain_destructor);
-
return result;
fail:
diff --git a/source3/winbindd/idmap_ad.c b/source3/winbindd/idmap_ad.c
index dfaa03497c..1984844d2a 100644
--- a/source3/winbindd/idmap_ad.c
+++ b/source3/winbindd/idmap_ad.c
@@ -695,14 +695,6 @@ done:
return ret;
}
-/************************************************************************
- ***********************************************************************/
-
-static NTSTATUS idmap_ad_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
/*
* nss_info_{sfu,sfu20,rfc2307}
*/
@@ -1065,17 +1057,6 @@ done:
return nt_status;
}
-
-/************************************************************************
- ***********************************************************************/
-
-static NTSTATUS nss_ad_close( void )
-{
- /* nothing to do. All memory is free()'d by the idmap close_fn() */
-
- return NT_STATUS_OK;
-}
-
/************************************************************************
Function dispatch tables for the idmap and nss plugins
***********************************************************************/
@@ -1084,7 +1065,6 @@ static struct idmap_methods ad_methods = {
.init = idmap_ad_initialize,
.unixids_to_sids = idmap_ad_unixids_to_sids,
.sids_to_unixids = idmap_ad_sids_to_unixids,
- .close_fn = idmap_ad_close
};
/* The SFU and RFC2307 NSS plugins share everything but the init
@@ -1095,7 +1075,6 @@ static struct nss_info_methods nss_rfc2307_methods = {
.get_nss_info = nss_ad_get_info,
.map_to_alias = nss_ad_map_to_alias,
.map_from_alias = nss_ad_map_from_alias,
- .close_fn = nss_ad_close
};
static struct nss_info_methods nss_sfu_methods = {
@@ -1103,7 +1082,6 @@ static struct nss_info_methods nss_sfu_methods = {
.get_nss_info = nss_ad_get_info,
.map_to_alias = nss_ad_map_to_alias,
.map_from_alias = nss_ad_map_from_alias,
- .close_fn = nss_ad_close
};
static struct nss_info_methods nss_sfu20_methods = {
@@ -1111,7 +1089,6 @@ static struct nss_info_methods nss_sfu20_methods = {
.get_nss_info = nss_ad_get_info,
.map_to_alias = nss_ad_map_to_alias,
.map_from_alias = nss_ad_map_from_alias,
- .close_fn = nss_ad_close
};
diff --git a/source3/winbindd/idmap_adex/idmap_adex.c b/source3/winbindd/idmap_adex/idmap_adex.c
index 1e815def70..c8d616b400 100644
--- a/source3/winbindd/idmap_adex/idmap_adex.c
+++ b/source3/winbindd/idmap_adex/idmap_adex.c
@@ -254,17 +254,6 @@ static NTSTATUS _idmap_adex_get_id_from_sid(struct
return NT_STATUS_OK;
}
-/**********************************************************************
- *********************************************************************/
-
-static NTSTATUS _idmap_adex_close(struct idmap_domain
- *dom)
-{
- /* FIXME! need to do cleanup here */
-
- return NT_STATUS_OK;
-}
-
/*
* IdMap NSS plugin
*/
@@ -383,7 +372,6 @@ static struct idmap_methods adex_idmap_methods = {
.init = _idmap_adex_init,
.unixids_to_sids = _idmap_adex_get_sid_from_id,
.sids_to_unixids = _idmap_adex_get_id_from_sid,
- .close_fn = _idmap_adex_close
};
static struct nss_info_methods adex_nss_methods = {
.init = _nss_adex_init,
diff --git a/source3/winbindd/idmap_autorid.c b/source3/winbindd/idmap_autorid.c
index ae65647ed6..f720a46fd1 100644
--- a/source3/winbindd/idmap_autorid.c
+++ b/source3/winbindd/idmap_autorid.c
@@ -567,17 +567,10 @@ static NTSTATUS idmap_autorid_initialize(struct idmap_domain *dom,
/*
Close the idmap tdb instance
*/
-static NTSTATUS idmap_autorid_close(struct idmap_domain *dom)
-{
- /* don't do anything */
- return NT_STATUS_OK;
-}
-
static struct idmap_methods autorid_methods = {
.init = idmap_autorid_initialize,
.unixids_to_sids = idmap_autorid_unixids_to_sids,
.sids_to_unixids = idmap_autorid_sids_to_unixids,
- .close_fn = idmap_autorid_close
};
NTSTATUS idmap_autorid_init(void)
diff --git a/source3/winbindd/idmap_hash/idmap_hash.c b/source3/winbindd/idmap_hash/idmap_hash.c
index 816e3a0532..61ae13ac3c 100644
--- a/source3/winbindd/idmap_hash/idmap_hash.c
+++ b/source3/winbindd/idmap_hash/idmap_hash.c
@@ -258,14 +258,6 @@ done:
/*********************************************************************
********************************************************************/
-static NTSTATUS be_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
-/*********************************************************************
- ********************************************************************/
-
static NTSTATUS nss_hash_init(struct nss_domain_entry *e )
{
return be_init(NULL, NULL);
@@ -359,7 +351,6 @@ static struct idmap_methods hash_idmap_methods = {
.init = be_init,
.unixids_to_sids = unixids_to_sids,
.sids_to_unixids = sids_to_unixids,
- .close_fn = be_close
};
static struct nss_info_methods hash_nss_methods = {
diff --git a/source3/winbindd/idmap_ldap.c b/source3/winbindd/idmap_ldap.c
index 56d2793c01..8444d01620 100644
--- a/source3/winbindd/idmap_ldap.c
+++ b/source3/winbindd/idmap_ldap.c
@@ -1149,18 +1149,12 @@ done:
Close the idmap ldap instance
**********************************/
-static NTSTATUS idmap_ldap_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
static struct idmap_methods idmap_ldap_methods = {
.init = idmap_ldap_db_init,
.unixids_to_sids = idmap_ldap_unixids_to_sids,
.sids_to_unixids = idmap_ldap_sids_to_unixids,
.allocate_id = idmap_ldap_get_new_id,
- .close_fn = idmap_ldap_close
};
NTSTATUS idmap_ldap_init(void);
diff --git a/source3/winbindd/idmap_nss.c b/source3/winbindd/idmap_nss.c
index e802288e50..5d5bd8c65e 100644
--- a/source3/winbindd/idmap_nss.c
+++ b/source3/winbindd/idmap_nss.c
@@ -210,17 +210,11 @@ static NTSTATUS idmap_nss_sids_to_unixids(struct idmap_domain *dom, struct id_ma
Close the idmap tdb instance
**********************************/
-static NTSTATUS idmap_nss_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
static struct idmap_methods nss_methods = {
.init = idmap_nss_int_init,
.unixids_to_sids = idmap_nss_unixids_to_sids,
.sids_to_unixids = idmap_nss_sids_to_unixids,
- .close_fn = idmap_nss_close
};
NTSTATUS idmap_nss_init(void)
diff --git a/source3/winbindd/idmap_passdb.c b/source3/winbindd/idmap_passdb.c
index 7f14b6bf38..ba179c331e 100644
--- a/source3/winbindd/idmap_passdb.c
+++ b/source3/winbindd/idmap_passdb.c
@@ -112,17 +112,11 @@ static NTSTATUS idmap_pdb_sids_to_unixids(struct idmap_domain *dom, struct id_ma
Close the idmap tdb instance
**********************************/
-static NTSTATUS idmap_pdb_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
static struct idmap_methods passdb_methods = {
.init = idmap_pdb_init,
.unixids_to_sids = idmap_pdb_unixids_to_sids,
.sids_to_unixids = idmap_pdb_sids_to_unixids,
- .close_fn =idmap_pdb_close
};
NTSTATUS idmap_passdb_init(void)
diff --git a/source3/winbindd/idmap_rid.c b/source3/winbindd/idmap_rid.c
index c87e77303d..935d7534fc 100644
--- a/source3/winbindd/idmap_rid.c
+++ b/source3/winbindd/idmap_rid.c
@@ -182,16 +182,10 @@ static NTSTATUS idmap_rid_sids_to_unixids(struct idmap_domain *dom, struct id_ma
return NT_STATUS_OK;
}
-static NTSTATUS idmap_rid_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
static struct idmap_methods rid_methods = {
.init = idmap_rid_initialize,
.unixids_to_sids = idmap_rid_unixids_to_sids,
.sids_to_unixids = idmap_rid_sids_to_unixids,
- .close_fn = idmap_rid_close
};
NTSTATUS idmap_rid_init(void)
diff --git a/source3/winbindd/idmap_tdb.c b/source3/winbindd/idmap_tdb.c
index 99e7414c7f..537f6cfb38 100644
--- a/source3/winbindd/idmap_tdb.c
+++ b/source3/winbindd/idmap_tdb.c
@@ -936,17 +936,11 @@ static NTSTATUS idmap_tdb_sids_to_unixids(struct idmap_domain *dom, struct id_ma
Close the idmap tdb instance
**********************************/
-static NTSTATUS idmap_tdb_close(struct idmap_domain *dom)
-{
- return NT_STATUS_OK;
-}
-
static struct idmap_methods db_methods = {
.init = idmap_tdb_db_init,
.unixids_to_sids = idmap_tdb_unixids_to_sids,
.sids_to_unixids = idmap_tdb_sids_to_unixids,
.allocate_id = idmap_tdb_get_new_id,
- .close_fn = idmap_tdb_close
};
NTSTATUS idmap_tdb_init(void)