diff options
| author | Jeremy Allison <jra@samba.org> | 2009-06-19 17:20:00 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2009-06-19 17:20:00 -0700 |
| commit | 271d09f5992bdfe1eba6cfb39563cc899eeda178 (patch) | |
| tree | 0f0faf41f05e95c87cb1cee81aacdb00f1137f48 | |
| parent | d9eb1d9764a27ae63c8d7f13d7f4148fd1833753 (diff) | |
| download | samba-271d09f5992bdfe1eba6cfb39563cc899eeda178.tar.gz samba-271d09f5992bdfe1eba6cfb39563cc899eeda178.tar.bz2 samba-271d09f5992bdfe1eba6cfb39563cc899eeda178.zip | |
Fix coverity #740. Resource leak in error paths. We should
always return queue here as the caller will free.
Jeremy.
| -rw-r--r-- | source3/printing/print_cups.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c index 18f42138c9..7d8248e428 100644 --- a/source3/printing/print_cups.c +++ b/source3/printing/print_cups.c @@ -1342,14 +1342,12 @@ static int cups_queue_get(const char *sharename, if ((response = cupsDoRequest(http, request, "/")) == NULL) { DEBUG(0,("Unable to get printer status for %s - %s\n", printername, ippErrorString(cupsLastError()))); - *q = queue; goto out; } if (response->request.status.status_code >= IPP_OK_CONFLICT) { DEBUG(0,("Unable to get printer status for %s - %s\n", printername, ippErrorString(response->request.status.status_code))); - *q = queue; goto out; } @@ -1377,13 +1375,14 @@ static int cups_queue_get(const char *sharename, fstrcpy(status->message, msg); } + out: + /* * Return the job queue... */ *q = queue; - out: if (response) ippDelete(response); |