summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2008-06-15 00:22:47 +0200
committerVolker Lendecke <vl@samba.org>2008-06-15 00:24:18 +0200
commit3fde7f5979fdf3f72df330a0c6977f677cca8a30 (patch)
treec7d9344673f692b347898a589803ff6195e9ee8e
parentcd7d7e1e8265324540276010f88b862f0afa68c0 (diff)
downloadsamba-3fde7f5979fdf3f72df330a0c6977f677cca8a30.tar.gz
samba-3fde7f5979fdf3f72df330a0c6977f677cca8a30.tar.bz2
samba-3fde7f5979fdf3f72df330a0c6977f677cca8a30.zip
Fix an uninitialized variable found by the IBM checker
BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's initialized. Stefan, please check! Volker (cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c) (This used to be commit 5663587e5e4703f9e3ff6d78d1f3248053ccd4c0)
-rw-r--r--source3/nsswitch/libwbclient/wbc_pwd.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/source3/nsswitch/libwbclient/wbc_pwd.c b/source3/nsswitch/libwbclient/wbc_pwd.c
index d23c378b5f..b5f167369c 100644
--- a/source3/nsswitch/libwbclient/wbc_pwd.c
+++ b/source3/nsswitch/libwbclient/wbc_pwd.c
@@ -394,16 +394,16 @@ wbcErr wbcGetGroups(const char *account,
uint32_t i;
gid_t *groups = NULL;
- if (!account) {
- wbc_status = WBC_ERR_INVALID_PARAM;
- BAIL_ON_WBC_ERROR(wbc_status);
- }
-
/* Initialize request */
ZERO_STRUCT(request);
ZERO_STRUCT(response);
+ if (!account) {
+ wbc_status = WBC_ERR_INVALID_PARAM;
+ BAIL_ON_WBC_ERROR(wbc_status);
+ }
+
/* Send request */
strncpy(request.data.username, account, sizeof(request.data.username)-1);