summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2012-03-03 17:02:01 +0100
committerVolker Lendecke <vl@samba.org>2012-03-03 23:38:31 +0100
commitc887cb6852ce6ec669f87c282aaaad55267c6d3e (patch)
tree13ca15586197e92fcc8e129fac5c12af6bc97d5e
parent58c26c2fd43051bb3910e8b7012ab37604da3ef5 (diff)
downloadsamba-c887cb6852ce6ec669f87c282aaaad55267c6d3e.tar.gz
samba-c887cb6852ce6ec669f87c282aaaad55267c6d3e.tar.bz2
samba-c887cb6852ce6ec669f87c282aaaad55267c6d3e.zip
s3: Fix a bogus if (client_len < 0)
On some platforms socklen_t might be unsigned, so comparing for <0 always returns true. Also, tsocket_address_bsd_sockaddr returns ssize_t. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sat Mar 3 23:38:31 CET 2012 on sn-devel-104
-rw-r--r--source3/rpc_server/spoolss/srv_spoolss_nt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index ed5edcc0ba..f66bea8197 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -2677,7 +2677,7 @@ WERROR _spoolss_RemoteFindFirstPrinterChangeNotifyEx(struct pipes_struct *p,
int snum = -1;
struct spoolss_NotifyOption *option = r->in.notify_options;
struct sockaddr_storage client_ss;
- socklen_t client_len;
+ ssize_t client_len;
/* store the notify value in the printer struct */