summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2010-11-09 13:24:03 -0800
committerJeremy Allison <jra@samba.org>2010-11-10 01:14:17 +0000
commit3878fa4c435140bd2e3c59f8bdb932fe19e4c13a (patch)
tree8412be4c1592dc181f17f748311702297f98adf5
parent9997ee813b8ceeb7016355bbc07651db7f6b2d5a (diff)
downloadsamba-3878fa4c435140bd2e3c59f8bdb932fe19e4c13a.tar.gz
samba-3878fa4c435140bd2e3c59f8bdb932fe19e4c13a.tar.bz2
samba-3878fa4c435140bd2e3c59f8bdb932fe19e4c13a.zip
Ensure we check the return from make_user_info before dereferencing the value returned by it.
Jeremy.
-rw-r--r--source3/auth/auth_ntlmssp.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/auth/auth_ntlmssp.c b/source3/auth/auth_ntlmssp.c
index 3905914884..4262d15a95 100644
--- a/source3/auth/auth_ntlmssp.c
+++ b/source3/auth/auth_ntlmssp.c
@@ -135,12 +135,12 @@ static NTSTATUS auth_ntlmssp_check_password(struct ntlmssp_state *ntlmssp_state,
NULL, NULL, NULL,
AUTH_PASSWORD_RESPONSE);
- user_info->logon_parameters = MSV1_0_ALLOW_SERVER_TRUST_ACCOUNT | MSV1_0_ALLOW_WORKSTATION_TRUST_ACCOUNT;
-
if (!NT_STATUS_IS_OK(nt_status)) {
return nt_status;
}
+ user_info->logon_parameters = MSV1_0_ALLOW_SERVER_TRUST_ACCOUNT | MSV1_0_ALLOW_WORKSTATION_TRUST_ACCOUNT;
+
nt_status = auth_ntlmssp_state->auth_context->check_ntlm_password(auth_ntlmssp_state->auth_context,
user_info, &auth_ntlmssp_state->server_info);