summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2010-04-28 14:36:10 +0200
committerStefan Metzmacher <metze@samba.org>2010-04-28 15:46:23 +0200
commit4783f84264d850bbceb995a1454eb01671e0c026 (patch)
tree2060ac1507b72401cf1c359d86506b39587152c3
parentae1c040b518273fd83797fcde170141aec9fe182 (diff)
downloadsamba-4783f84264d850bbceb995a1454eb01671e0c026.tar.gz
samba-4783f84264d850bbceb995a1454eb01671e0c026.tar.bz2
samba-4783f84264d850bbceb995a1454eb01671e0c026.zip
s3:smbd: add comment about returning STATUS_BUFFER_OVERFLOW in pipe_read_andx_done()
metze
-rw-r--r--source3/smbd/pipes.c16
1 files changed, 15 insertions, 1 deletions
diff --git a/source3/smbd/pipes.c b/source3/smbd/pipes.c
index 9bc3fdfdf6..aff5f53495 100644
--- a/source3/smbd/pipes.c
+++ b/source3/smbd/pipes.c
@@ -449,7 +449,21 @@ static void pipe_read_andx_done(struct tevent_req *subreq)
state->outbuf = NULL;
srv_set_message((char *)req->outbuf, 12, nread, False);
-
+
+#if 0
+ /*
+ * we should return STATUS_BUFFER_OVERFLOW if there's
+ * out standing data.
+ *
+ * But we can't enable it yet, as it has bad interactions
+ * with fixup_chain_error_packet() in chain_reply().
+ */
+ if (is_data_outstanding) {
+ error_packet_set((char *)req->outbuf, ERRDOS, ERRmoredata,
+ STATUS_BUFFER_OVERFLOW, __LINE__, __FILE__);
+ }
+#endif
+
SSVAL(req->outbuf,smb_vwv5,nread);
SSVAL(req->outbuf,smb_vwv6,
req_wct_ofs(req)