summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Adam <obnox@samba.org>2008-07-08 15:33:36 +0200
committerMichael Adam <obnox@samba.org>2008-07-08 16:02:33 +0200
commit6ae40a8b74aadcd6f1ead5c141e39c160b773546 (patch)
tree717a80866b0a365c346d3a6af8fd10464f5a11b4
parent2cb149b0b3dfce4a036956ba7d575af5bc144cc4 (diff)
downloadsamba-6ae40a8b74aadcd6f1ead5c141e39c160b773546.tar.gz
samba-6ae40a8b74aadcd6f1ead5c141e39c160b773546.tar.bz2
samba-6ae40a8b74aadcd6f1ead5c141e39c160b773546.zip
tdbtool: fix off-by-one error in argument length. (bug #2344)
This prevented all commands operating on keys (all non-traverse commands) in tdbtool to fail with a "fetch failed" or "delete failed" message. It seems that it fixes bug #2344 ... Apparently this bug was introduced with 94e53472666ed in 2005. Either nobody is using tdbtool or else tdb_find() has become more strict about the key legth in the meantime. :-) Michael (This used to be commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115)
-rw-r--r--source4/lib/tdb/tools/tdbtool.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/lib/tdb/tools/tdbtool.c b/source4/lib/tdb/tools/tdbtool.c
index d104ccd7c4..500e441c6a 100644
--- a/source4/lib/tdb/tools/tdbtool.c
+++ b/source4/lib/tdb/tools/tdbtool.c
@@ -598,7 +598,7 @@ static char *convert_string(char *instring, size_t *sizep)
}
length++;
}
- *sizep = length;
+ *sizep = length + 1;
return instring;
}