summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Dieter Wallnöfer <mdw@samba.org>2010-06-12 17:50:52 +0200
committerMatthias Dieter Wallnöfer <mdw@samba.org>2010-06-12 17:50:52 +0200
commit731b4469cb3b074a39b21fee220517af3df26a68 (patch)
tree3377719e06832aa69a85b110434b9aeec38b7b15
parenta67fa2db3b48d48d3460e4cc1d9826a107b64066 (diff)
downloadsamba-731b4469cb3b074a39b21fee220517af3df26a68.tar.gz
samba-731b4469cb3b074a39b21fee220517af3df26a68.tar.bz2
samba-731b4469cb3b074a39b21fee220517af3df26a68.zip
s4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found
This shouldn't happen since SIDs are mandatory for security objects
-rw-r--r--source4/rpc_server/samr/dcesrv_samr.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c
index c11caee877..9aab2b8b43 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -3418,8 +3418,7 @@ static NTSTATUS dcesrv_samr_GetGroupsForUser(struct dcesrv_call_state *dce_call,
group_sid = samdb_result_dom_sid(mem_ctx, res[i], "objectSid");
if (group_sid == NULL) {
- DEBUG(0, ("Couldn't find objectSid attrib\n"));
- continue;
+ return NT_STATUS_INTERNAL_DB_CORRUPTION;
}
array->rids[i + 1].rid =