summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2001-07-24 01:18:43 +0000
committerJeremy Allison <jra@samba.org>2001-07-24 01:18:43 +0000
commit76f36b8c360c427fbcc19aa043a3c4b923fd37e7 (patch)
treeea59c58426a9d87994287756c21ae905d8f476cd
parenta4947d1f45b0ddcddfd6f77d130e510820a95a40 (diff)
downloadsamba-76f36b8c360c427fbcc19aa043a3c4b923fd37e7.tar.gz
samba-76f36b8c360c427fbcc19aa043a3c4b923fd37e7.tar.bz2
samba-76f36b8c360c427fbcc19aa043a3c4b923fd37e7.zip
We were making an assumption in the oplock
break code path that was invalid (ie. we were assuming we could infer a non-levelII oplock when such an oplock was detected - this may no longer be valid once we've processed the break process dealing with the break will change the state of it anyway. This prevents the state where we get the following packet trace : client server NTcreate -> <- NTcreate resp NTcreate -> <- break to level II ok - broken -> <- break to none Thanks to Alan Romeril for providing the trace that allowed me to track this down. Jeremy. (This used to be commit c343e4f49070011986fc2ed4acd4ce690d5f1d71)
-rw-r--r--source3/smbd/open.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index f67490b61d..a32e032921 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -506,7 +506,6 @@ dev = %x, inode = %.0f\n", old_shares[i].op_type, fname, (unsigned int)dev, (dou
}
broke_oplock = True;
- *p_all_current_opens_are_level_II = False;
break;
} else if (!LEVEL_II_OPLOCK_TYPE(share_entry->op_type)) {