summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2000-09-12 19:51:38 +0000
committerJeremy Allison <jra@samba.org>2000-09-12 19:51:38 +0000
commit7ec53a14b149bcf90cf38548a0d9044286b3e3bb (patch)
tree6f637ac882aa9f405f2e309b5e6bea716b403808
parent072d39165d63b960fea583b65d9a4d110466bea8 (diff)
downloadsamba-7ec53a14b149bcf90cf38548a0d9044286b3e3bb.tar.gz
samba-7ec53a14b149bcf90cf38548a0d9044286b3e3bb.tar.bz2
samba-7ec53a14b149bcf90cf38548a0d9044286b3e3bb.zip
With John Reilly help tracking it down - fixed a *nasty* bug when
authorising logins. If a user connected to a share as guest, then the snum was getting flagged as "force guest", meaning that all subsequent connections to it, even under a different vuid, would be bounced to guest. This explains several very hard to reproduce access denied bugs, and as the NT client also has bugs in that it will sometimes erroneously use guest instead of the correct vuid on an IPC$ connection lead to a *very* hard problem to find. This fix should be propagated into all branches (TNG/Applience take note) and I'll also make a separate patch availalble on the samba-technical list. Jeremy. (This used to be commit 0264fdafe909cf9e995df3ae7b64bedbe0b4e8a1)
-rw-r--r--source3/smbd/password.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/source3/smbd/password.c b/source3/smbd/password.c
index fe3c9fea0f..da01cf4f37 100644
--- a/source3/smbd/password.c
+++ b/source3/smbd/password.c
@@ -818,7 +818,6 @@ BOOL authorise_login(int snum,char *user,char *password, int pwlen,
else
DEBUG(0,("Invalid guest account %s??\n",guestname));
*guest = True;
- *force = True;
}
if (ok && !user_ok(user,snum))