summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2009-10-22 12:45:48 +1100
committerAndrew Tridgell <tridge@samba.org>2009-10-22 12:47:55 +1100
commita109ee71fb9b8fa25f9ca739caaba5a1399b7864 (patch)
treec81ef01ce275dfd1f4ce81cc11a983829debdeb7
parentf2988f5cad156da54e7ad41c2c2d8bd7a0ee29b8 (diff)
downloadsamba-a109ee71fb9b8fa25f9ca739caaba5a1399b7864.tar.gz
samba-a109ee71fb9b8fa25f9ca739caaba5a1399b7864.tar.bz2
samba-a109ee71fb9b8fa25f9ca739caaba5a1399b7864.zip
s4-ldb: added a TODO about checking the indexlist
-rw-r--r--source4/lib/ldb/ldb_tdb/ldb_index.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/source4/lib/ldb/ldb_tdb/ldb_index.c b/source4/lib/ldb/ldb_tdb/ldb_index.c
index 04c3c7acce..0d560fea5e 100644
--- a/source4/lib/ldb/ldb_tdb/ldb_index.c
+++ b/source4/lib/ldb/ldb_tdb/ldb_index.c
@@ -428,6 +428,8 @@ static bool ltdb_is_indexed(const struct ldb_message *index_list, const char *at
if (el == NULL) {
return false;
}
+
+ /* TODO: this is too expensive! At least use a binary search */
for (i=0; i<el->num_values; i++) {
if (ldb_attr_cmp((char *)el->values[i].data, attr) == 0) {
return true;