diff options
| author | Michael Adam <obnox@samba.org> | 2010-05-17 10:39:00 +0200 |
|---|---|---|
| committer | Michael Adam <obnox@samba.org> | 2010-05-17 11:45:31 +0200 |
| commit | a15b6664389b05ea0cded46de3abe53034a7edef (patch) | |
| tree | 2dba7f40ee84239ebfe05e263c56d3b93a3ac06f | |
| parent | 765e9c7c67058271365521ce415b2ec1483e3c3d (diff) | |
| download | samba-a15b6664389b05ea0cded46de3abe53034a7edef.tar.gz samba-a15b6664389b05ea0cded46de3abe53034a7edef.tar.bz2 samba-a15b6664389b05ea0cded46de3abe53034a7edef.zip | |
s3:winbind:idmap_tdb: don't check ranges when an invalid entry was found.
There is no point in checking the ranges this if the record found had an
invalid/unknown type: the mapping is not filled in. If it were initialized
to some defaults before, the check just might replace the status
NT_STATUS_INTERNAL_DB_ERROR with a NT_STATUS_NONE_MAPPED, which is not
as precise.
| -rw-r--r-- | source3/winbindd/idmap_tdb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/winbindd/idmap_tdb.c b/source3/winbindd/idmap_tdb.c index 8bfe751a8b..45266abe15 100644 --- a/source3/winbindd/idmap_tdb.c +++ b/source3/winbindd/idmap_tdb.c @@ -792,6 +792,7 @@ static NTSTATUS idmap_tdb_sid_to_id(struct idmap_tdb_context *ctx, struct id_map } else { /* Unknown record type ! */ DEBUG(2, ("Found INVALID record %s -> %s\n", keystr, (const char *)data.dptr)); ret = NT_STATUS_INTERNAL_DB_ERROR; + goto done; } /* apply filters before returning result */ |