diff options
| author | Arvid Requate <requate@univention.de> | 2012-03-02 13:59:30 +0100 |
|---|---|---|
| committer | Nadezhda Ivanova <nivanova@samba.org> | 2012-03-02 21:26:40 +0100 |
| commit | b1cedbbeea14e67cbce32d6ab152c6c5413ba7d8 (patch) | |
| tree | ab728080cb1e5d5ae729d38508cf648cbb245407 | |
| parent | 95976d4ec2111a5be7dab2698de35537a10536a1 (diff) | |
| download | samba-b1cedbbeea14e67cbce32d6ab152c6c5413ba7d8.tar.gz samba-b1cedbbeea14e67cbce32d6ab152c6c5413ba7d8.tar.bz2 samba-b1cedbbeea14e67cbce32d6ab152c6c5413ba7d8.zip | |
SEGV in acl_validate_spn_value: dnsHostName NULL
This patch addresses a segfault in acl_validate_spn_value which occurs
when the "dnsHostName" attribute is missing. This seems to be the case
in domains migrated with samba3upgrade. Looks similar to MS KB 817543.
Signed-off-by: Nadezhda Ivanova <nivanova@drizzit.(none)>
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Fri Mar 2 21:26:40 CET 2012 on sn-devel-104
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/acl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/acl.c b/source4/dsdb/samdb/ldb_modules/acl.c index abde85f682..6aed6825cb 100644 --- a/source4/dsdb/samdb/ldb_modules/acl.c +++ b/source4/dsdb/samdb/ldb_modules/acl.c @@ -516,7 +516,7 @@ static int acl_validate_spn_value(TALLOC_CTX *mem_ctx, if (strlen(instanceName) == (strlen(samAccountName) - 1) && strncasecmp(instanceName, samAccountName, strlen(samAccountName) - 1) == 0) { goto success; - } else if (strcasecmp(instanceName, dnsHostName) == 0) { + } else if (dnsHostName != NULL && strcasecmp(instanceName, dnsHostName) == 0) { goto success; } else if (is_dc) { const char *guid_str; |