diff options
| author | Christopher R. Hertel <crh@redhat.com> | 2013-08-29 16:58:16 -0500 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2013-08-30 02:43:48 +0200 |
| commit | ba04400d01c6ad05651672e087527391da7fdaf4 (patch) | |
| tree | f4f3608d215bc01246efa709abfdf3e69fc2ad9b | |
| parent | 91910fe898e2f8ad405c5790aa1a20e82a9f8aac (diff) | |
| download | samba-ba04400d01c6ad05651672e087527391da7fdaf4.tar.gz samba-ba04400d01c6ad05651672e087527391da7fdaf4.tar.bz2 samba-ba04400d01c6ad05651672e087527391da7fdaf4.zip | |
vfs_glusterfs: Fix excessive debug output from vfs_gluster_open().
The vfs_gluster_open() function generates a debug message (at level 0)
for every failed attempt to open a pathname. This includes cases in
which attempts are made to open a directory as a file (those attempts
are retried calling vfs_gluster_opendir()). The result is that the log
file fills with messages about failed attempts to open directories, just
because they are directories.
This latest version, of the patch completely removes logging from the
vfs_gluster_open() function. The error code returned is handled in
upper layers, and the open function in the default VFS module does not
log any errors.
Signed-off-by: Christopher R. Hertel <crh@redhat.com>
Reviewed-by: susant palai <spalai@redhat.com>
Reviewed-by: raghavendra talur <rtalur@redhat.com>
Reviewed-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Aug 30 02:43:48 CEST 2013 on sn-devel-104
| -rw-r--r-- | source3/modules/vfs_glusterfs.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c index eac1b240c3..237236a1df 100644 --- a/source3/modules/vfs_glusterfs.c +++ b/source3/modules/vfs_glusterfs.c @@ -481,11 +481,8 @@ static int vfs_gluster_open(struct vfs_handle_struct *handle, } if (glfd == NULL) { - DEBUG(0, ("glfs_{open[dir],creat}(%s) failed: %s\n", - smb_fname->base_name, strerror(errno))); return -1; } - return glfd_fd_store(glfd); } |