summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2010-01-13 12:00:27 +0100
committerStefan Metzmacher <metze@samba.org>2010-01-13 16:03:53 +0100
commitf715414afa7cb06af07bfd362bf340f6b13f7acb (patch)
treeb60922c2880b328bb6ad55eda05a28395d15f625
parent7d41afece70093e2debf2b57731c85ecc5009765 (diff)
downloadsamba-f715414afa7cb06af07bfd362bf340f6b13f7acb.tar.gz
samba-f715414afa7cb06af07bfd362bf340f6b13f7acb.tar.bz2
samba-f715414afa7cb06af07bfd362bf340f6b13f7acb.zip
s4:dsdb/schema_load: add a TODO about schema reloading
metze
-rw-r--r--source4/dsdb/samdb/ldb_modules/schema_load.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/schema_load.c b/source4/dsdb/samdb/ldb_modules/schema_load.c
index 6c11df21ce..3442e821ce 100644
--- a/source4/dsdb/samdb/ldb_modules/schema_load.c
+++ b/source4/dsdb/samdb/ldb_modules/schema_load.c
@@ -204,7 +204,17 @@ static int schema_load_extended(struct ldb_module *module, struct ldb_request *r
if (strcmp(req->op.extended.oid, DSDB_EXTENDED_SCHEMA_UPDATE_NOW_OID) != 0) {
return ldb_next_request(module, req);
}
-
+
+ /*
+ * TODO:
+ *
+ * We should check "schemaInfo" if we really need to reload the schema!
+ *
+ * We should also for a new schema version at the start of each
+ * "write" (add/modify/rename/delete) operation. And have tests
+ * to prove that windows does the same.
+ */
+
schema_dn = samdb_schema_dn(ldb);
if (!schema_dn) {
ldb_reset_err_string(ldb);