summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2011-03-03 16:20:56 +0100
committerVolker Lendecke <vl@samba.org>2011-03-03 22:08:49 +0100
commitf8a13c7dbc9b0e2246fb52d4a4d5db3b23bd2340 (patch)
tree10312f7a40bba8019dca5ab87c06d30bf62be238
parentae28029f6788c2cbb31b2f1c9d0bf47d75bf398d (diff)
downloadsamba-f8a13c7dbc9b0e2246fb52d4a4d5db3b23bd2340.tar.gz
samba-f8a13c7dbc9b0e2246fb52d4a4d5db3b23bd2340.tar.bz2
samba-f8a13c7dbc9b0e2246fb52d4a4d5db3b23bd2340.zip
s3: Use dom_sid_string in _lsa_lookup_sids_internal
-rw-r--r--source3/rpc_server/lsa/srv_lsa_nt.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/source3/rpc_server/lsa/srv_lsa_nt.c b/source3/rpc_server/lsa/srv_lsa_nt.c
index 70e7ba59aa..a4fc40a58b 100644
--- a/source3/rpc_server/lsa/srv_lsa_nt.c
+++ b/source3/rpc_server/lsa/srv_lsa_nt.c
@@ -897,7 +897,6 @@ static NTSTATUS _lsa_lookup_sids_internal(struct pipes_struct *p,
struct lsa_name_info *name = &name_infos[i];
if (name->type == SID_NAME_UNKNOWN) {
- fstring tmp;
name->dom_idx = -1;
/* Unknown sids should return the string
* representation of the SID. Windows 2003 behaves
@@ -905,9 +904,7 @@ static NTSTATUS _lsa_lookup_sids_internal(struct pipes_struct *p,
* RID as 8 bytes hex, in others it returns the full
* SID. We (Jerry/VL) could not figure out which the
* hard cases are, so leave it with the SID. */
- name->name = talloc_asprintf(p->mem_ctx, "%s",
- sid_to_fstring(tmp,
- sids[i]));
+ name->name = dom_sid_string(p->mem_ctx, sids[i]);
if (name->name == NULL) {
return NT_STATUS_NO_MEMORY;
}