summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2008-04-01 18:18:38 +0200
committerStefan Metzmacher <metze@samba.org>2008-04-01 18:47:42 +0200
commit5b07337cc5e853d0f02554593f4eb842191d67e5 (patch)
tree49e0d86ed3c955d985aca8b264baede50cb15db1
parent175622fa58b2c9a0e3afaf3d5045ee4f569bf508 (diff)
downloadsamba-5b07337cc5e853d0f02554593f4eb842191d67e5.tar.gz
samba-5b07337cc5e853d0f02554593f4eb842191d67e5.tar.bz2
samba-5b07337cc5e853d0f02554593f4eb842191d67e5.zip
smbd: always close the base_fsp even if the real close returned an error
Otherwise we may end up with share mode entry without an open file. Volker, Jeremy: please check... metze (This used to be commit 547eacf6058d2bc5b41b266b70f8f4747aca4eae)
-rw-r--r--source3/smbd/close.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/source3/smbd/close.c b/source3/smbd/close.c
index 4bd23a35fc..b06c0d1e9c 100644
--- a/source3/smbd/close.c
+++ b/source3/smbd/close.c
@@ -665,10 +665,6 @@ NTSTATUS close_file(files_struct *fsp, enum file_close_type close_type)
status = close_normal_file(fsp, close_type);
}
- if (!NT_STATUS_IS_OK(status)) {
- return status;
- }
-
if ((base_fsp != NULL) && (close_type != SHUTDOWN_CLOSE)) {
/*