diff options
| author | Jeremy Allison <jra@samba.org> | 2009-07-17 17:36:26 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2009-07-17 17:36:26 -0700 |
| commit | 6a9e0039100b57f9626e87defec6720c476b9789 (patch) | |
| tree | 614ea76e56332e7c647514997195b6098d0e326d | |
| parent | 33251da8611ddc98c3ae73d62601218e5b784e63 (diff) | |
| download | samba-6a9e0039100b57f9626e87defec6720c476b9789.tar.gz samba-6a9e0039100b57f9626e87defec6720c476b9789.tar.bz2 samba-6a9e0039100b57f9626e87defec6720c476b9789.zip | |
Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.
| -rw-r--r-- | source3/rpc_server/srv_spoolss_nt.c | 4 | ||||
| -rw-r--r-- | source3/smbd/server.c | 1 |
2 files changed, 5 insertions, 0 deletions
diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c index 48ac103667..9dc1a26e3b 100644 --- a/source3/rpc_server/srv_spoolss_nt.c +++ b/source3/rpc_server/srv_spoolss_nt.c @@ -309,7 +309,9 @@ static WERROR delete_printer_hook(TALLOC_CTX *ctx, NT_USER_TOKEN *token, const c return WERR_BADFID; /* What to return here? */ /* go ahead and re-read the services immediately */ + become_root(); reload_services(false); + unbecome_root(); if ( lp_servicenumber( sharename ) < 0 ) return WERR_ACCESS_DENIED; @@ -6034,7 +6036,9 @@ bool add_printer_hook(TALLOC_CTX *ctx, NT_USER_TOKEN *token, NT_PRINTER_INFO_LEV } /* reload our services immediately */ + become_root(); reload_services(false); + unbecome_root(); numlines = 0; /* Get lines and convert them back to dos-codepage */ diff --git a/source3/smbd/server.c b/source3/smbd/server.c index a1dec0327c..4b1c803d75 100644 --- a/source3/smbd/server.c +++ b/source3/smbd/server.c @@ -94,6 +94,7 @@ static void smb_conf_updated(struct messaging_context *msg, { DEBUG(10,("smb_conf_updated: Got message saying smb.conf was " "updated. Reloading.\n")); + change_to_root_user(); reload_services(False); } |