summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Adam <obnox@samba.org>2012-09-04 15:23:01 +0200
committerMichael Adam <obnox@samba.org>2012-09-04 20:39:20 +0200
commit6c7df39feeaeebeca88562e575aa0c803559b0d7 (patch)
tree130e4cca7a71526b895138bf59f73fd374c1daf4
parent1d4fe78db928c5f68aa805d1f5dc6a941fbb10fc (diff)
downloadsamba-6c7df39feeaeebeca88562e575aa0c803559b0d7.tar.gz
samba-6c7df39feeaeebeca88562e575aa0c803559b0d7.tar.bz2
samba-6c7df39feeaeebeca88562e575aa0c803559b0d7.zip
s3: in sys_popen(), untangle function call from result check
-rw-r--r--source3/lib/system.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/source3/lib/system.c b/source3/lib/system.c
index 9460330537..58f7b478ad 100644
--- a/source3/lib/system.c
+++ b/source3/lib/system.c
@@ -1188,8 +1188,10 @@ int sys_popen(const char *command)
* Extract the command and args into a NULL terminated array.
*/
- if(!(argl = extract_args(NULL, command)))
+ argl = extract_args(NULL, command);
+ if (argl == NULL) {
goto err_exit;
+ }
entry->child_pid = fork();