diff options
| author | Jeremy Allison <jra@samba.org> | 2008-05-20 14:18:58 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2008-05-20 14:20:47 -0700 |
| commit | 6d4424cd45333c3029b0272528485dd2b3f8e620 (patch) | |
| tree | eb6a24e9328158f41306f16477997be8cb3500d4 | |
| parent | aa7e4b8e9cafaa5139b5111aa8ca042e6b6f65f4 (diff) | |
| download | samba-6d4424cd45333c3029b0272528485dd2b3f8e620.tar.gz samba-6d4424cd45333c3029b0272528485dd2b3f8e620.tar.bz2 samba-6d4424cd45333c3029b0272528485dd2b3f8e620.zip | |
Convert in_transaction to a bool. Add the same fix Volker
used for tdb_traverse() to tdb_traverse_read().
Jeremy.
(This used to be commit e05ec3047c4fe0cc2e09a812830fc835dc35abea)
| -rw-r--r-- | source4/lib/tdb/common/traverse.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/source4/lib/tdb/common/traverse.c b/source4/lib/tdb/common/traverse.c index 5a31742e7b..69c81e6e98 100644 --- a/source4/lib/tdb/common/traverse.c +++ b/source4/lib/tdb/common/traverse.c @@ -204,18 +204,23 @@ int tdb_traverse_read(struct tdb_context *tdb, { struct tdb_traverse_lock tl = { NULL, 0, 0, F_RDLCK }; int ret; + bool in_transaction = (tdb->transaction != NULL); /* we need to get a read lock on the transaction lock here to cope with the lock ordering semantics of solaris10 */ - if (tdb_transaction_lock(tdb, F_RDLCK)) { - return -1; + if (!in_transaction) { + if (tdb_transaction_lock(tdb, F_RDLCK)) { + return -1; + } } tdb->traverse_read++; ret = tdb_traverse_internal(tdb, fn, private_data, &tl); tdb->traverse_read--; - tdb_transaction_unlock(tdb); + if (!in_transaction) { + tdb_transaction_unlock(tdb); + } return ret; } @@ -232,7 +237,7 @@ int tdb_traverse(struct tdb_context *tdb, { struct tdb_traverse_lock tl = { NULL, 0, 0, F_WRLCK }; int ret; - int in_transaction = (tdb->transaction != NULL); + bool in_transaction = (tdb->transaction != NULL); if (tdb->read_only || tdb->traverse_read) { return tdb_traverse_read(tdb, fn, private_data); |