summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2012-05-09 10:56:54 +0200
committerVolker Lendecke <vl@samba.org>2012-05-10 09:11:57 +0200
commit6d5bbb9a4bd3d1fb045f4e0873196a9b1d93ae2a (patch)
tree5ea356bb146bb4af32189087b26e151be3a1bdbf
parentbd4701d2869c8f5271c72fe4271c2ba4772acfad (diff)
downloadsamba-6d5bbb9a4bd3d1fb045f4e0873196a9b1d93ae2a.tar.gz
samba-6d5bbb9a4bd3d1fb045f4e0873196a9b1d93ae2a.tar.bz2
samba-6d5bbb9a4bd3d1fb045f4e0873196a9b1d93ae2a.zip
s3: Fix Coverity ID 242716 Uninitialized scalar variable
In an error path we are closing key_hnd without opening it
-rw-r--r--source3/rpc_client/cli_winreg_spoolss.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/rpc_client/cli_winreg_spoolss.c b/source3/rpc_client/cli_winreg_spoolss.c
index a0bbd91c7d..4aa1f28cb9 100644
--- a/source3/rpc_client/cli_winreg_spoolss.c
+++ b/source3/rpc_client/cli_winreg_spoolss.c
@@ -2907,7 +2907,8 @@ WERROR winreg_printer_setform1(TALLOC_CTX *mem_ctx,
struct spoolss_AddFormInfo1 *form)
{
uint32_t access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
- struct policy_handle hive_hnd, key_hnd;
+ struct policy_handle hive_hnd;
+ struct policy_handle key_hnd = { 0, };
struct winreg_String wvalue = { 0, };
DATA_BLOB blob;
uint32_t num_builtin = ARRAY_SIZE(builtin_forms1);