summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2011-07-06 09:37:04 +0200
committerVolker Lendecke <vl@samba.org>2011-07-06 09:50:02 +0200
commit6fcb3bbdae835f513e5c539eddb437f2ae4c1c88 (patch)
tree4f4726c0eda320d45ea73e9814034537a8496a67
parent7d96a4594bcbaa75d82779d70e2dec658b9508d6 (diff)
downloadsamba-6fcb3bbdae835f513e5c539eddb437f2ae4c1c88.tar.gz
samba-6fcb3bbdae835f513e5c539eddb437f2ae4c1c88.tar.bz2
samba-6fcb3bbdae835f513e5c539eddb437f2ae4c1c88.zip
s3: Fix Coverity ID 2586 -- NO_EFFECT
tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is unsigned. So (len < 0) could never have turned true. Volker
-rw-r--r--source3/lib/util_sock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/lib/util_sock.c b/source3/lib/util_sock.c
index a35bd58d11..5154a83fec 100644
--- a/source3/lib/util_sock.c
+++ b/source3/lib/util_sock.c
@@ -1135,7 +1135,7 @@ int get_remote_hostname(const struct tsocket_address *remote_address,
char tmp_name[MAX_DNS_NAME_LENGTH];
struct name_addr_pair nc;
struct sockaddr_storage ss;
- socklen_t len;
+ ssize_t len;
int rc;
if (!lp_hostname_lookups()) {