summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJelmer Vernooij <jelmer@samba.org>2008-05-07 17:30:47 +0200
committerJelmer Vernooij <jelmer@samba.org>2008-09-15 17:36:59 +0200
commit947bde9562917e8948af93f86e90653ec717d47c (patch)
tree75275c669626d6e86c8eeced721979f9b92bbb0b
parent15ebda7e1b18cc29be891b1370473c8bc3acc2c6 (diff)
downloadsamba-947bde9562917e8948af93f86e90653ec717d47c.tar.gz
samba-947bde9562917e8948af93f86e90653ec717d47c.tar.bz2
samba-947bde9562917e8948af93f86e90653ec717d47c.zip
Avoid using unions without discriminants.
-rw-r--r--source4/librpc/idl/wmi.idl4
-rw-r--r--source4/pidl/TODO5
2 files changed, 7 insertions, 2 deletions
diff --git a/source4/librpc/idl/wmi.idl b/source4/librpc/idl/wmi.idl
index 6726ffa050..0fb35cde20 100644
--- a/source4/librpc/idl/wmi.idl
+++ b/source4/librpc/idl/wmi.idl
@@ -414,7 +414,7 @@ interface IWbemClassObject : IUnknown
uint32 __PROPERTY_COUNT;
WbemProperty properties[__PROPERTY_COUNT];
uint8 default_flags[__PROPERTY_COUNT];
- CIMVAR default_values[__PROPERTY_COUNT];
+ uint32 /*CIMVAR*/ default_values[__PROPERTY_COUNT];
} WbemClass;
typedef [public] struct
@@ -439,7 +439,7 @@ interface IWbemClassObject : IUnknown
uint8 u1_0;
[relative,charset(UTF16)] uint16 *__CLASS;
uint8 *default_flags;
- CIMVAR *data;
+ uint32 /*CIMVAR*/ *data;
uint32 u2_4;
uint8 u3_1;
} WbemInstance;
diff --git a/source4/pidl/TODO b/source4/pidl/TODO
index bc5c49a46f..8886441a75 100644
--- a/source4/pidl/TODO
+++ b/source4/pidl/TODO
@@ -1,3 +1,8 @@
+- warn when union instances don't have a discriminant
+
+- EJS output backend shouldn't use the NDR levels stuff but instead
+ as the "C levels" and NDR levels don't necessarily match.
+
- true multiple dimension array / strings in arrays support
- compatibility mode for generating MIDL-readable data: