diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-07-23 08:18:31 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:38:19 -0500 |
| commit | aac411b7dddefeafc0762dade882a769fc99069e (patch) | |
| tree | 17caeb1e959da758eebda280e290aa827b13fddc | |
| parent | 528477effa70e2adb9d03b977e4a6a12973a7e1a (diff) | |
| download | samba-aac411b7dddefeafc0762dade882a769fc99069e.tar.gz samba-aac411b7dddefeafc0762dade882a769fc99069e.tar.bz2 samba-aac411b7dddefeafc0762dade882a769fc99069e.zip | |
r17199: Add comment to the RID/SID miracle
(This used to be commit 4c4ae01c671bd35687af686a34824a96828e6b25)
| -rw-r--r-- | source3/rpc_server/srv_lsa_nt.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/source3/rpc_server/srv_lsa_nt.c b/source3/rpc_server/srv_lsa_nt.c index 04747406d4..41df870414 100644 --- a/source3/rpc_server/srv_lsa_nt.c +++ b/source3/rpc_server/srv_lsa_nt.c @@ -873,7 +873,12 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p, if (name->type == SID_NAME_UNKNOWN) { name->dom_idx = -1; - /* unknown sids should return the string representation of the SID */ + /* Unknown sids should return the string + * representation of the SID. Windows 2003 behaves + * rather erratic here, in many cases it returns the + * RID as 8 bytes hex, in others it returns the full + * SID. We (Jerry/VL) could not figure out which the + * hard cases are, so leave it with the SID. */ name->name = talloc_asprintf(p->mem_ctx, "%s", sid_string_static(sids[i])); if (name->name == NULL) { |