summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2004-07-16 03:57:04 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 12:57:39 -0500
commitbacee255dd06e0e5ab0d8d8af9dc006bc6b794cc (patch)
tree8bc88b0eef600d1f995faf0db2ee3ddcdeb8cfd6
parentafb48b55ae978942c0ca44548ac1a570b9df4d6a (diff)
downloadsamba-bacee255dd06e0e5ab0d8d8af9dc006bc6b794cc.tar.gz
samba-bacee255dd06e0e5ab0d8d8af9dc006bc6b794cc.tar.bz2
samba-bacee255dd06e0e5ab0d8d8af9dc006bc6b794cc.zip
r1523: declaring variables "in" and "out" in every C module is a bad idea!
I actually don't like this idea of sharing the request buffer structure between client and server, and I'll see if I can convince abartlet to revert it. It ties the two pieces of code far more intimately than is justified, and will certainly lead to ugliness as the client and server take different paths of development. I would far prefer we just pass 2 arguments (pointer and length) to the signing calls instead of 1 (the request). (This used to be commit 70838a921185c091d0e774dd5fb0546693999e8f)
-rw-r--r--source4/include/request.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/include/request.h b/source4/include/request.h
index 476cfb2a6a..7dae579c24 100644
--- a/source4/include/request.h
+++ b/source4/include/request.h
@@ -35,7 +35,7 @@ struct request_buffer {
*/
uint_t allocated;
- /* the start of the SMB header - this is always buffer+4 */
+ /* the start of the SMB header - this is always buffer+4 */
char *hdr;
/* the command words and command word count. vwv points
@@ -53,5 +53,5 @@ struct request_buffer {
* a send packet is done we need to move this
* pointer */
char *ptr;
-} in, out;
+};