summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2008-03-21 10:40:40 +0100
committerVolker Lendecke <vl@samba.org>2008-03-21 10:40:40 +0100
commitc69c5c132ade57d1eb860ae8f73b0e48de0e5c6f (patch)
treef5824e853f37878658ac1c940d00231979c0208c
parent35cab4a8c27b3471557bbbd04d8bcf49dfec51c0 (diff)
downloadsamba-c69c5c132ade57d1eb860ae8f73b0e48de0e5c6f.tar.gz
samba-c69c5c132ade57d1eb860ae8f73b0e48de0e5c6f.tar.bz2
samba-c69c5c132ade57d1eb860ae8f73b0e48de0e5c6f.zip
Fix Coverity ID 547
Günther, please check. If r->in.ads==NULL, we can't call ads_leave_realm at all. Thanks, Volker (This used to be commit 120d8c889fa9ad61c74f1f936e83537513454648)
-rw-r--r--source3/libnet/libnet_join.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c
index d3fba167d9..52376ac821 100644
--- a/source3/libnet/libnet_join.c
+++ b/source3/libnet/libnet_join.c
@@ -264,10 +264,7 @@ static ADS_STATUS libnet_unjoin_remove_machine_acct(TALLOC_CTX *mem_ctx,
ADS_STATUS status;
if (!r->in.ads) {
- status = libnet_unjoin_connect_ads(mem_ctx, r);
- if (!ADS_ERR_OK(status)) {
- return status;
- }
+ return libnet_unjoin_connect_ads(mem_ctx, r);
}
status = ads_leave_realm(r->in.ads, r->in.machine_name);