summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2012-05-15 19:26:48 +0200
committerVolker Lendecke <vl@samba.org>2012-05-15 21:37:17 +0200
commitfc77ee51717d3ca8e7d50ff46f2738cee475a84f (patch)
tree70103ed7391054d55714f08725fb9f1850d71375
parent229862224301e3fa3fc30cd495a7ff9ee7ca4b60 (diff)
downloadsamba-fc77ee51717d3ca8e7d50ff46f2738cee475a84f.tar.gz
samba-fc77ee51717d3ca8e7d50ff46f2738cee475a84f.tar.bz2
samba-fc77ee51717d3ca8e7d50ff46f2738cee475a84f.zip
s3: Fix Coverity ID 242710 Untrusted pointer read
According to susv3 we have to make sure that we call isupper with values only in the range of an unsigned char. This is best achieved by automatic narrowing through assignment.
-rw-r--r--source3/utils/net_registry_check.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/utils/net_registry_check.c b/source3/utils/net_registry_check.c
index 8d1a91c44b..6e455db2d8 100644
--- a/source3/utils/net_registry_check.c
+++ b/source3/utils/net_registry_check.c
@@ -788,7 +788,7 @@ static int check_tdb_action(struct db_record *rec, void *check_ctx)
}
if (invalid_path) {
- int action;
+ unsigned char action;
if (ctx->opt.output == NULL) {
action = first_iter ? 'r' : 's';
} else if (ctx->opt.automatic) {