summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Potter <tpot@samba.org>2001-12-17 01:53:02 +0000
committerTim Potter <tpot@samba.org>2001-12-17 01:53:02 +0000
commit0be611c8dcab438674362773495417bd846e11f2 (patch)
treee5bec68af4d57d509e3942b2f04a3a1870a927f3
parent55e0930a29312e8c5e9575efcdb62606cd9b8a2f (diff)
downloadsamba-0be611c8dcab438674362773495417bd846e11f2.tar.gz
samba-0be611c8dcab438674362773495417bd846e11f2.tar.bz2
samba-0be611c8dcab438674362773495417bd846e11f2.zip
Replaced some hardcoded hex numbers with constants.
Made a note about NOTIFY_OPTION_TYPE and NOTIFY_OPTION_TYPE_DATA - they are actually one structure. The latter is just the deferred referrant of the former. (This used to be commit b596c0b171b1fd0e25e52944c880e8a90bc10a2e)
-rw-r--r--source3/rpc_parse/parse_spoolss.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index c2d462ad40..f6d629f857 100644
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -192,6 +192,10 @@ static BOOL smb_io_doc_info_container(char *desc, DOC_INFO_CONTAINER *cont, prs_
reads or writes an NOTIFY OPTION TYPE structure.
********************************************************************/
+/* NOTIFY_OPTION_TYPE and NOTIFY_OPTION_TYPE_DATA are really one
+ structure. The _TYPE structure is really the deferred referrants (i.e
+ the notify fields array) of the _TYPE structure. -tpot */
+
static BOOL smb_io_notify_option_type(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
{
prs_debug(ps, depth, desc, "smb_io_notify_option_type");
@@ -5590,10 +5594,10 @@ BOOL spoolss_io_q_setprinterdata(char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_st
switch (q_u->type)
{
- case 0x1:
- case 0x3:
- case 0x4:
- case 0x7:
+ case REG_SZ:
+ case REG_BINARY:
+ case REG_DWORD:
+ case REG_MULTI_SZ:
if (q_u->max_len) {
if (UNMARSHALLING(ps))
q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));