summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2011-03-16 21:48:50 +0100
committerVolker Lendecke <vl@samba.org>2011-03-16 22:07:24 +0100
commit37870e28ab4ef0ebcec0ed18714a6fef9a5a16d4 (patch)
treedd0cc3085ef44f1a1531ebb47899cfd4d410ef71
parentdacb392db6b7585bffe00fae11aab4cc6225c072 (diff)
downloadsamba-37870e28ab4ef0ebcec0ed18714a6fef9a5a16d4.tar.gz
samba-37870e28ab4ef0ebcec0ed18714a6fef9a5a16d4.tar.bz2
samba-37870e28ab4ef0ebcec0ed18714a6fef9a5a16d4.zip
s3: Fix Coverity ID 2233, REVERSE_INULL
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
-rw-r--r--source3/rpc_server/netlogon/srv_netlog_nt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
index bfa3bb25e8..e5d61242e3 100644
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
@@ -490,7 +490,7 @@ NTSTATUS _netr_NetrEnumerateTrustedDomains(struct pipes_struct *p,
status = NT_STATUS_OK;
out:
- if (h && is_valid_policy_hnd(&pol)) {
+ if (is_valid_policy_hnd(&pol)) {
dcerpc_lsa_Close(h, p->mem_ctx, &pol, &result);
}